Feat: Support IPv6 UDP sockets #56
Conversation
|
Since I've changed the default from 0.0.0.0 to :: it seems like I'll have to change the tests here as well (almost forgot about this PR actually... will finish this up this weekend) |
There was a problem hiding this comment.
nice effort, if we keep the host default CI should be 🟢
please also add a version bump and a changelog entry ... here's a sample PR for how to do so:
https://github.com/logstash-plugins/logstash-input-syslog/pull/61/files#diff-77118e4da74a8181e929b617ccdc9504R4
|
💚 CLA has been signed |
|
I've also signed the agreement (I thought I already done that...) |
|
you need to make sure to sign it with the e-mail address you have in your commits |
|
Oooopsie, totally overlooked the version bump and changelog part, will fix that ASAP! |
|
I've added a version bump as well as a changelog entry |
|
Friendly reminder on this PR :-) |
Co-authored-by: Karol Bucek <kares@users.noreply.github.com>
It seems that UDP isn't correctly binding to IPv6, this seems to be because ruby requires an UDP socket to have a specific INET variable set. This pull-request parses the listening IP-address and opens the correct variant of the UDP socket.